feat(List): add prop gap #7094
Merged
feat(List): add prop gap #7094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Добавил prop gap для установки промежутка между элементами в компоненте List Доработал drag and drop, чтобы работал также корректно
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit ddadf9f |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7094 +/- ##
==========================================
- Coverage 83.91% 83.90% -0.02%
==========================================
Files 357 357
Lines 10785 10796 +11
Branches 3557 3561 +4
==========================================
+ Hits 9050 9058 +8
- Misses 1735 1738 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
inomdzhon
reviewed
Jun 27, 2024
inomdzhon
previously approved these changes
Jun 28, 2024
# Conflicts: # packages/vkui/src/components/List/List.tsx # packages/vkui/src/hooks/useDraggableWithDomApi/utils.ts
SevereCloud
reviewed
Jul 1, 2024
inomdzhon
approved these changes
Jul 4, 2024
SevereCloud
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Добавил prop gap для установки промежутка между элементами в компоненте List Доработал drag and drop, чтобы работал также корректно