feat: add pressets to storybook props #7389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit 8cdd3a4 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7389 +/- ##
=======================================
Coverage 94.50% 94.50%
=======================================
Files 375 375
Lines 11116 11116
Branches 3641 3641
=======================================
Hits 10505 10505
Misses 611 611
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mendrew
previously approved these changes
Aug 16, 2024
inomdzhon
reviewed
Aug 19, 2024
BlackySoul
reviewed
Aug 20, 2024
packages/vkui/src/components/ActionSheetItem/ActionSheetItem.stories.tsx
Show resolved
Hide resolved
BlackySoul
reviewed
Aug 20, 2024
BlackySoul
reviewed
Aug 20, 2024
# Conflicts: # packages/vkui/src/components/CustomSelect/CustomSelect.stories.tsx
mendrew
approved these changes
Aug 22, 2024
BlackySoul
approved these changes
Aug 22, 2024
| ✅ v6.6.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Сейчас в
Storybookв компонентах, где можно прокинуть например иконку в prop, в панели controls отображается непонятный объект, который еще и нельзя поменять из интерфейса. Нужно сделать этот процесс удобнее. Как вариант - это добавление пресетов иконок(и не только).Изменения
createFieldWithPresets, которая генерирует маппинг названия иконок в саму иконку.