-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
permit FQN forms for the global function names #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that supporting functions in namespaces is not a huge deal and we can implement it.
But if you don't consider it useful right now just left it as it is.
@eugene536 I'm mostly concerned about unqualified function names resolution that can't be done in |
7db304d
to
9c638ea
Compare
9c638ea
to
e711e7d
Compare
Since FQN names always resolve to the name without leading '\', we can start with this and implement real function namespaces support later (https://www.php.net/manual/en/language.namespaces.rules.php). This change makes it possible to compile PHP projects that refer to global functions using full qualified names. Here is an example: https://github.com/symfony/polyfill-ctype/blob/main/Ctype.php#L36
e711e7d
to
7eee2f2
Compare
Rebased, tested for diff. |
Since FQN names always resolve to the name without leading '',
we can start with this and implement real function namespaces
support later (https://www.php.net/manual/en/language.namespaces.rules.php).
This change makes it possible to compile PHP projects that refer
to global functions using full qualified names.
Here is an example: https://github.com/symfony/polyfill-ctype/blob/main/Ctype.php#L36