fix race in resolving defines and checking defaults #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexK0
reviewed
Nov 28, 2020
eugene536
force-pushed
the
fix_race_when_check_abstract_defaults
branch
from
8894850
to
fe2fc60
Compare
eugene536
force-pushed
the
fix_race_when_check_abstract_defaults
branch
from
fe2fc60
to
74f6f51
Compare
AlexK0
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we check that the default argument of interface or abstract method has the same value as every overloaded method from derived classes we have a data race.
InlineDefinesUsagesPasstries can inline defines used as default value at the same time when we investigate such a situation.Now we separate that check and do it after the synchronization pipe
GenerateVirtualMethods.