Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes in tracing binlog writer #859

Merged
merged 3 commits into from
Jun 29, 2023
Merged

Fixes in tracing binlog writer #859

merged 3 commits into from
Jun 29, 2023

Conversation

DrDet
Copy link
Contributor

@DrDet DrDet commented Jun 23, 2023 •
edited
Loading

Here're 2 fixes:

  • Changed offset for fork id calculation. Before, calculated ids didn't fit 24 bits which caused overflows
  • Implement dynamic precision to store wait net times > 16 sec to 24 bits

@DrDet DrDet added the small fix When it's not an huge enhancement label Jun 23, 2023
@DrDet DrDet added this to the next milestone Jun 23, 2023
@DrDet DrDet requested a review from tolk-vm June 23, 2023 17:40
@DrDet DrDet self-assigned this Jun 23, 2023
tolk-vm
tolk-vm previously approved these changes Jun 29, 2023
View reviewed changes
@DrDet DrDet changed the title Fix fork id calculation in kphp tracing Fixes in tracing binlog writer Jun 29, 2023
@DrDet DrDet merged commit 46a74d2 into master Jun 29, 2023
@DrDet DrDet deleted the dvaksman/fix-fork-ids branch June 29, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolk-vm tolk-vm tolk-vm approved these changes

Assignees

@DrDet DrDet

Labels
small fix When it's not an huge enhancement
Projects
None yet
Milestone
30.06.2023
Development

Successfully merging this pull request may close these issues.
2 participants
@DrDet @tolk-vm