Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter special chars from json logs. #92

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Filter special chars from json logs. #92

merged 1 commit into from
Jan 13, 2021

Conversation

AlexK0
Copy link
Contributor

@AlexK0 AlexK0 commented Jan 13, 2021

This patch allows to remove special chars from json logs.

@AlexK0 AlexK0 force-pushed the alexko/KPHP-1211-fix-json-log branch from 4aaa1bb to 016cf51 Compare January 13, 2021 08:11
quasilyte
quasilyte previously approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@quasilyte quasilyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a test for non-space iscntrl character, so we have ? in the output?
Otherwise LGTM.

@AlexK0 AlexK0 force-pushed the alexko/KPHP-1211-fix-json-log branch from 016cf51 to 81d89ca Compare January 13, 2021 08:43
@tolk-vm tolk-vm added this to the next milestone Jan 13, 2021
@AlexK0 AlexK0 merged commit aefa7b4 into master Jan 13, 2021
@AlexK0 AlexK0 deleted the alexko/KPHP-1211-fix-json-log branch January 13, 2021 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quasilyte quasilyte quasilyte approved these changes

@tolk-vm tolk-vm tolk-vm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
28.01.2021
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexK0 @quasilyte @tolk-vm