tech: добавляет линтеры и GitHub Actions Workflow на PR #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add ESLint * Add Prettier * Add Editorconfig
inomdzhon
added a commit
that referenced
this pull request
Jun 5, 2023
inomdzhon
force-pushed
the
imirdzhamolov/issue342/tech/add-linters-and-ci
branch
from
ce43ae0
to
b85ff34
Compare
inomdzhon
added a commit
that referenced
this pull request
Jun 5, 2023
evg-evdokimov
approved these changes
Jun 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Теперь в артефакт в NPM будут попадать только
dist/,README.md,LICENSEиpackage.json.Note
Заменил
.npmignoreна поле"files"вpackage.json, а то сейчас добавляется много лишнегоhttps://www.npmjs.com/package/@vkontakte/vk-bridge/v/2.7.4?activeTab=code
Теперь при коммите будут запускаться линты для проверки измененных файлов на кодстайл.
Теперь при создании PR будет запускаться
workflow, который запускает тесты и линты.Теперь все файлы соответствуют код стайлу на основе @vkontakte/eslint-plugin и @vkontakte/prettier-config.