Updated fonts for vkCom theme #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Test suite run success422 tests passing in 37 suites. Report generated by 🧪jest coverage report action from 370128a |
8coon
approved these changes
Jun 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Изменение нужно, чтобы VKCOM могли безболезненно перевезти шрифты со своих переменных
--palette-vkна наши токены.В предыдущей попытке столкнулись с различием — у нас был
system-uiв токенах шрифтов, и обновление задело пользователей, которые не пользуются Apple. ТеперьfontFamilyBaseсовпадает с--palette-vk-font, аfontFamilyAccentсовпадает с--vk-sans-display.