Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): added fontSize and basic implementation of textStyles #24

Closed
wants to merge 1 commit into from

Conversation

gabrieleAngius
Copy link
Collaborator

Proposed changes

started adding font-related slices, added a basic implementation of a dropdown

wip #22

Types of changes

  • ✨ New feature (non-breaking change which adds functionality or enhancements)
  • 🐛 Bugfix (non-breaking change which fixes an issue)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ✅ Tests (added tests for an existing feature)
  • 📚 Chore / Documentation Update (if none of the other choices apply)
  • 🙌 Other (please, write a clear and concise description of the proposal in the section above)

Checklist

  • ✂️ I have ensured that the PR is concise and broken down if needed
  • 👀 I have read the README doc
  • 🧪 I have added tests that prove my fix is effective or that my feature works
  • 📚 I have added necessary documentation (if appropriate)
  • 🔀 Any dependent changes have been merged and published in downstream modules

started adding font-related slices, added a basic implementation of a dropdown

wip #22
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.06 🎉

Comparison is base (dea53c6) 98.64% compared to head (a27d854) 98.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
+ Coverage   98.64%   98.71%   +0.06%     
==========================================
  Files          24       26       +2     
  Lines         444      466      +22     
  Branches       83       86       +3     
==========================================
+ Hits          438      460      +22     
  Misses          6        6              
Impacted Files Coverage Δ
widget-src/components/FontSizes/deleteFontSize.ts 100.00% <100.00%> (ø)
widget-src/components/Radii/utils.ts 95.45% <100.00%> (ø)
...get-src/components/TextStyles/setTextStyleValue.ts 100.00% <100.00%> (ø)
widget-src/constants.ts 100.00% <100.00%> (ø)
widget-src/hooks/useInitTheme.ts 98.00% <100.00%> (+0.17%) ⬆️
widget-src/parsers/sliceItemsToMorfeo.ts 100.00% <100.00%> (ø)
widget-src/types.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gabrieleAngius
Copy link
Collaborator Author

Dropping this feature due to #25

@gabrieleAngius gabrieleAngius deleted the feat/22 branch June 27, 2023 07:51
@gabrieleAngius gabrieleAngius added the wontfix This will not be worked on label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant