Feature/lando update #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ase hostname from 'db' to 'database' to match Lando. Updated settings.php scaffolding to match config for both.
michaelsmithvmlyr
requested review from
vml-kkedrovsky,
spfaffly,
garrettrathbone,
pthurmond-vmlyr and
jimmy-courtice
| @@ -1,6 +1,8 @@ | |||
| version: "2.1" | |||
|
|
|||
| services: | |||
| db: | |||
| hostname: database | |||
There was a problem hiding this comment.
Does Lando use "database" as the hostname and is that why you are changing it here?
There was a problem hiding this comment.
Yes. It's easier to change in docksal than it is in lando.
pthurmond-vmlyr
approved these changes
May 31, 2022
pthurmond-vmlyr
approved these changes
Jun 8, 2022
|
Is there any reason we can't merge this? |
…hen starting lando. Add the directory to .gitignore so that new logs files aren't uploaded.
…to feature/lando-update
pthurmond-vmlyr
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added lando support to D9 version.