Feature/gulp update 2 #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spfaffly
reviewed
Apr 8, 2019
source/package.json
Outdated
| "name": "subtheme", | ||
| "description": "Subtheme file for us in KIT-related projects", | ||
| "name": "unitedrentals", | ||
| "description": "UR: Drupal 8 KIT common theme support", |
There was a problem hiding this comment.
Probably change the name and description back to something KIT related.
There was a problem hiding this comment.
good catch! sorry that got moved in
| @@ -2,49 +2,28 @@ | |||
| "name": "subtheme", | |||
| "description": "Subtheme file for us in KIT-related projects", | |||
| "author": "", | |||
| "version": "8.1.2", | |||
| "version": "1.0.0", | |||
There was a problem hiding this comment.
I feel like we should make this 8.2.0, to follow convention that it's made for Drupal 8. Similarly, I was thinking I'd make our new tools be 8.2 as well, to make sure that we have a deprecated tool set for all of the current sites.
| function buildImages() { | ||
| const tasks = config.map(function(entry) { | ||
| return src('themes/custom/' + entry.themeName + '/images/**/*') | ||
| .pipe(changed(entry.destDir + '/img')) |
There was a problem hiding this comment.
Should this be the directory in the "dest" task below?
|
Closed since Karl's PR has this included. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if this doesn't work see Garrett 😉