Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crashes when deleting items #1332

Merged
merged 1 commit into from
Aug 17, 2024
Merged

Fix crashes when deleting items #1332

merged 1 commit into from
Aug 17, 2024

Conversation

VMelnalksnis
Copy link
Owner

Fixes #1259

Changes proposed in this pull request:

  • Use a command instead of binding to method
  • Fix refreshes after deleting
  • Merge ICommandFactory into IActivityService

@VMelnalksnis VMelnalksnis added type:bug Something isn't working area:ui Relating to user interface labels Aug 17, 2024
Copy link

codecov bot commented Aug 17, 2024

Codecov Report

Attention: Patch coverage is 89.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 70.62%. Comparing base (d2ec65c) to head (6a7ec10).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1332      +/-   ##
==========================================
+ Coverage   70.60%   70.62%   +0.01%     
==========================================
  Files         539      538       -1     
  Lines       13642    13636       -6     
  Branches     1047     1047              
==========================================
- Hits         9632     9630       -2     
+ Misses       3655     3653       -2     
+ Partials      355      353       -2     
Components Coverage Δ
API 77.62% <ø> (ø)
UI 61.09% <89.33%> (+0.02%) ⬆️

@VMelnalksnis VMelnalksnis merged commit 6a7ec10 into master Aug 17, 2024
13 checks passed
@VMelnalksnis VMelnalksnis deleted the binding branch August 17, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ui Relating to user interface type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application crashes when deleting purchase
1 participant