-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
修正: cpu_num_threadsが未指定または0の場合に、論理コア数の半分をコアに渡すようにする #1113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👍
os.cpu_count()
による論理コア数取得に基づいてバグが修正されています。過剰なCPUリソース消費の防止により UX 改善が見込まれます。丁寧なテストも good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMです!!
修正ありがとうございます!
ドキュメントの修正を確認しました。 |
こちら、一応破壊的変更の扱いで進めたいと思っています! |
内容
cpu_num_threads
が未指定または0の場合に、論理コア数の半分をコアに渡すようにするos.cpu_count()
はNone
を返す可能性があり、その場合は以前と同様0を返す関連 Issue
close #1092