-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pysen lint extrasの利用をやめ、linterを更新する #608
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takana-v
approved these changes
Feb 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hiroshiba
approved these changes
Feb 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
丁寧な進行助かります!!
requirements系の差分を見ていましたが、ちゃんと-test.txt
内での差分だけだったので大丈夫そうに思いました。
手元でpullしてformatterかけてみたりしました感じだと差分も発生しなかったので、良い感じなのかなと思います!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
mypyのバージョンをPython 3.9以降と互換性のある0.900以降に上げるため、pysen lint extrasの利用をやめ、各linterライブラリに個別に依存するようにします。
また、各linterを利用できる最新版に更新します(
poetry lock --no-update
で更新したので、関係のないライブラリのバージョンは変わっていないはず...)。pysen lint extrasは、以下で
black
の依存関係が問題になったとき、pysen
を更新して利用を維持することになりましたが、このPRでは、Python 3.9以降への更新のため、各linterのバージョンを指定することが必要になりました。
flake8がPython 3.8.1以上を要求するため、
pyproject.toml
上のPython要求バージョンをPython 3.8.1以上に更新しています。linter更新によって、べき乗のフォーマットルールが変わったようで、その対応もしています。
関連 Issue
スクリーンショット・動画など
その他