Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

整理: AquesTalk風記法パース規則コメントの追加 #864

Merged
merged 5 commits into from
Dec 17, 2023

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented Dec 13, 2023

内容

AquesTalk風記法パーサーにおける、規則-実装対応コメントの追加

関連 Issue

resolve #850

依存 Issues

以下の issues / PRs に依存、これらが解決の後、reviewとマージ可能

Copy link

github-actions bot commented Dec 13, 2023

Coverage Result

Resultを開く
Name Stmts Miss Cover
run.py 487 333 coverage-32%
voicevox_engine/init.py 1 0 coverage-100%
voicevox_engine/cancellable_engine.py 91 71 coverage-22%
voicevox_engine/core_wrapper.py 208 150 coverage-28%
voicevox_engine/dev/core/init.py 2 0 coverage-100%
voicevox_engine/dev/core/mock.py 27 12 coverage-56%
voicevox_engine/dev/synthesis_engine/init.py 2 0 coverage-100%
voicevox_engine/dev/synthesis_engine/mock.py 38 2 coverage-95%
voicevox_engine/engine_manifest/EngineManifest.py 34 0 coverage-100%
voicevox_engine/engine_manifest/EngineManifestLoader.py 12 0 coverage-100%
voicevox_engine/engine_manifest/init.py 3 0 coverage-100%
voicevox_engine/library_manager.py 93 5 coverage-95%
voicevox_engine/metas/Metas.py 33 0 coverage-100%
voicevox_engine/metas/MetasStore.py 18 8 coverage-56%
voicevox_engine/metas/init.py 2 0 coverage-100%
voicevox_engine/model.py 162 9 coverage-94%
voicevox_engine/morphing.py 70 46 coverage-34%
voicevox_engine/part_of_speech_data.py 5 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetError.py 2 0 coverage-100%
voicevox_engine/preset/PresetManager.py 81 2 coverage-98%
voicevox_engine/preset/init.py 4 0 coverage-100%
voicevox_engine/setting/Setting.py 11 0 coverage-100%
voicevox_engine/setting/SettingLoader.py 18 0 coverage-100%
voicevox_engine/setting/init.py 3 0 coverage-100%
voicevox_engine/tts_pipeline/init.py 5 0 coverage-100%
voicevox_engine/tts_pipeline/acoustic_feature_extractor.py 25 1 coverage-96%
voicevox_engine/tts_pipeline/full_context_label.py 165 3 coverage-98%
voicevox_engine/tts_pipeline/kana_parser.py 86 1 coverage-99%
voicevox_engine/tts_pipeline/make_tts_engines.py 59 30 coverage-49%
voicevox_engine/tts_pipeline/mora_list.py 4 0 coverage-100%
voicevox_engine/tts_pipeline/tts_engine.py 185 13 coverage-93%
voicevox_engine/tts_pipeline/tts_engine_base.py 71 10 coverage-86%
voicevox_engine/user_dict.py 144 12 coverage-92%
voicevox_engine/utility/init.py 5 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 37 0 coverage-100%
voicevox_engine/utility/core_version_utility.py 8 1 coverage-88%
voicevox_engine/utility/mutex_utility.py 10 0 coverage-100%
voicevox_engine/utility/path_utility.py 26 8 coverage-69%
TOTAL 2249 717 coverage-68%

@tarepan tarepan marked this pull request as ready for review December 15, 2023 18:06
@tarepan tarepan requested a review from a team as a code owner December 15, 2023 18:06
@tarepan tarepan requested review from y-chan and removed request for a team December 15, 2023 18:06
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほぼLGTMです!!!
すごくわかりやすいと思います!!

ちょっと提案があったのでコメントしてみました。
とはいえコメントに対するコメントなので、お手数おかけしてもという気持ちもあり、ちょっとプルリクに対してプルリクを送ってみるというのをやってみたのでご確認いただければ!!

(ちょっと作業量的に重かったので、たぶん今回だけになると思います。。)

voicevox_engine/tts_pipeline/kana_parser.py Outdated Show resolved Hide resolved
voicevox_engine/tts_pipeline/kana_parser.py Outdated Show resolved Hide resolved
@tarepan
Copy link
Contributor Author

tarepan commented Dec 17, 2023

提案いただいた PR を review・merge しました👍

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

voicevox_engine/tts_pipeline/kana_parser.py Outdated Show resolved Hide resolved
@Hiroshiba Hiroshiba merged commit 3bd9199 into VOICEVOX:master Dec 17, 2023
3 checks passed
@tarepan tarepan deleted the refactor/perser_rule branch December 17, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: AquesTalk風記法パーサーの文法規則コメント
2 participants