-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
整理: 疑問形 upspeak の単純化 #904
Merged
Merged
整理: 疑問形 upspeak の単純化 #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
上位関数において query 自体が deepcopy されている。よって本関数における deepcopy は複製される last_mora のみで必要十分である。
tarepan
force-pushed
the
refactor/upspeak
branch
from
December 20, 2023 02:33
c407960
to
7a645cc
Compare
Hiroshiba
reviewed
Dec 21, 2023
Hiroshiba
reviewed
Dec 21, 2023
Hiroshiba
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
概要: 疑問形 upspeak 処理の単純化によるリファクタリング
ネストの解消・処理の簡素化によってリファクタリングをおこなった。
関連 Issue
part of #897
Reviewer 向け情報
3つの関数ネストを削除したため、diff が機能していません。
commit ごとに 1 つの関数を削除したため、レビュー時には commit log を参照していただければ幸いです。