Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audio_queryのe2eテスト #967

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

Hiroshiba
Copy link
Member

内容

↓のチェックにあると便利そうだったので導入しました。

関連 Issue

その他

スナップショットファイルと目的の対応がわかりやすい&テストの内容がわかりやすいように、def test_[テストの目的]という関数を許容する方針の提案も含んでいます。
こうしておけば、何を対象としているのかわかりやすくなり、テストの目的コメントを省けて、スナップショットのわかりやすいファイル名を書き足す必要もなくなるので、良いかなと・・・。

(テストフレームワークが充実していれば、it("テストの目的")みたいな形で書けるのですが。。)

@y-chan さんや @takana-v さんや @tarepan さん的にどうでしょう・・・?

@Hiroshiba Hiroshiba requested a review from a team as a code owner January 2, 2024 15:04
@Hiroshiba Hiroshiba requested review from y-chan and removed request for a team January 2, 2024 15:04
Copy link

github-actions bot commented Jan 2, 2024

Coverage Result

Resultを開く
Name Stmts Miss Cover
run.py 507 326 coverage-36%
voicevox_engine/init.py 1 0 coverage-100%
voicevox_engine/cancellable_engine.py 93 72 coverage-23%
voicevox_engine/core_adapter.py 51 17 coverage-67%
voicevox_engine/core_initializer.py 59 30 coverage-49%
voicevox_engine/core_wrapper.py 224 159 coverage-29%
voicevox_engine/dev/core/init.py 2 0 coverage-100%
voicevox_engine/dev/core/mock.py 36 8 coverage-78%
voicevox_engine/dev/tts_engine/init.py 2 0 coverage-100%
voicevox_engine/dev/tts_engine/mock.py 26 0 coverage-100%
voicevox_engine/engine_manifest/EngineManifest.py 34 0 coverage-100%
voicevox_engine/engine_manifest/EngineManifestLoader.py 12 0 coverage-100%
voicevox_engine/engine_manifest/init.py 3 0 coverage-100%
voicevox_engine/library_manager.py 92 5 coverage-95%
voicevox_engine/metas/Metas.py 33 0 coverage-100%
voicevox_engine/metas/MetasStore.py 18 6 coverage-67%
voicevox_engine/metas/init.py 2 0 coverage-100%
voicevox_engine/model.py 163 9 coverage-94%
voicevox_engine/morphing.py 71 46 coverage-35%
voicevox_engine/part_of_speech_data.py 5 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetError.py 2 0 coverage-100%
voicevox_engine/preset/PresetManager.py 80 2 coverage-98%
voicevox_engine/preset/init.py 4 0 coverage-100%
voicevox_engine/setting/Setting.py 11 0 coverage-100%
voicevox_engine/setting/SettingLoader.py 17 0 coverage-100%
voicevox_engine/setting/init.py 3 0 coverage-100%
voicevox_engine/tts_pipeline/init.py 3 0 coverage-100%
voicevox_engine/tts_pipeline/acoustic_feature_extractor.py 26 0 coverage-100%
voicevox_engine/tts_pipeline/kana_converter.py 86 1 coverage-99%
voicevox_engine/tts_pipeline/mora_list.py 4 0 coverage-100%
voicevox_engine/tts_pipeline/text_analyzer.py 132 6 coverage-95%
voicevox_engine/tts_pipeline/tts_engine.py 187 8 coverage-96%
voicevox_engine/user_dict.py 145 12 coverage-92%
voicevox_engine/utility/init.py 5 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 37 0 coverage-100%
voicevox_engine/utility/core_version_utility.py 8 1 coverage-88%
voicevox_engine/utility/mutex_utility.py 13 0 coverage-100%
voicevox_engine/utility/path_utility.py 35 9 coverage-74%
voicevox_engine/utility/run_utility.py 10 7 coverage-30%
TOTAL 2254 724 coverage-68%

Copy link
Contributor

@tarepan tarepan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

正常系・異常系のテストが漏れなく記載されています👍
日本語含む関数・ファイル名も「現行のテスト環境下でテスト意図を明示する」目的に対して適切な手法と感じます👍
good work!

@Hiroshiba
Copy link
Member Author

レビューありがとうございます!!
問題があれば方針変えれば良さそうなので、とりあえずマージします!

@Hiroshiba Hiroshiba merged commit dc597c0 into VOICEVOX:master Jan 3, 2024
3 checks passed
@Hiroshiba Hiroshiba deleted the audio_queryのe2eテスト branch January 3, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants