Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGENT_CONFIG not existing should be an error #2952

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

gwenkidd
Copy link
Contributor

Description

Added a ValueError that is raised in load_config when the config_path does not exist.

Fixes #2847

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tried installing some example agents with an agent config path that does not exist and was given an error. The error that is displayed is thrown in the install_agent_directory function which runs before we reach the load_config function so we don't see the load_config error.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gwenkidd gwenkidd changed the title #2847 AGENT_CONFIG not existing should be an error AGENT_CONFIG not existing should be an error Apr 13, 2022
@schandrika schandrika linked an issue Apr 15, 2022 that may be closed by this pull request
@schandrika schandrika merged commit 1ff1173 into VOLTTRON:develop Apr 15, 2022
@gwenkidd
Copy link
Contributor Author

Closes #2847

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AGENT_CONFIG not existing should be an error
2 participants