Actuator and driver agent fixes #3170
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidraker
force-pushed
the
actuator_agent_fixes
branch
from
46193d7
to
b6d29ad
Compare
craig8
requested changes
May 10, 2024
| except errors.VIPError: | ||
| _log.warning("Error trying to ping device.") | ||
| except (Exception, gevent.Timeout) as e: | ||
| _log.warning(f"Error trying to ping device: {e}") |
There was a problem hiding this comment.
e won't have the device address or the device_id. Please change the warning to be for the device.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for actuator schedule requests and exception handling in driver agent related to BACnet ping and heartbeat signals.
Checklist: