Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with 'CTRL + P' #8581

Open
RiskExe opened this issue Sep 11, 2023 · 4 comments
Open

Conflict with 'CTRL + P' #8581

RiskExe opened this issue Sep 11, 2023 · 4 comments

Comments

@RiskExe
Copy link

RiskExe commented Sep 11, 2023

'CTRL + P' is an essential code navigation tool in native vscode. I really value being able to seemlessly navigate a codebase through the keyboard, as I'm sure many of us vim users can relate to.

Suddenly I find myself unable to use this amazing code navigation tool built in to vscode because VsCodeVim is now using it for seemingly no reason. This happened on both my PC and laptop yesterday so this has to have been some update.

Of course this was easy to rectify. Just delete the VscodeVim binding and you're all set. But having the extension's whole userbase all of a sudden have to identify and solve this problem seems ridiculous. To be honest I don't even know what vim's use for the binding is, but whatever it was it can occupy another keyboard binding.

@srackhall
Copy link

vim.mode == 'SearchInProgressMode'

I think it may be caused by the failure of this' when 'expression, but unfortunately, I don't know how to solve this problem. Because this shortcut key is still useful to me in search mode, I cannot handle this issue by deleting or modifying the shortcut key. I hope friends who are also facing this situation can provide some help.

@Panzer04
Copy link

Panzer04 commented Sep 12, 2023

The issue is that "suggestWidgetVisible" was removed from the old keymapping.

Previously the ctrl-p keymapping would apply what seems to be an up action when the editor was suggesting an autocomplete. Now, it's remapping it in all circumstances to up. It needs to be readded to fix the issue (or just remove? I don't really understand why it's present in the first place, but I am no Vim guru)

@ShadowManu
Copy link

Just an extra note in case anyone wonders how to quickly workaround this in the meantime, edit your settings.json file with:

{
  "vim.handleKeys": {
    "<C-p>": false
  }
}

@davdmoo
Copy link

davdmoo commented Sep 12, 2023

I think the same issue has been mentioned in #8574

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants
@ShadowManu @Panzer04 @srackhall @RiskExe @davdmoo and others