Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert mode keystrokes are sometimes dropped since 1.26.0 #8603

Closed
TommyX12 opened this issue Sep 17, 2023 · 13 comments
Closed

Insert mode keystrokes are sometimes dropped since 1.26.0 #8603

TommyX12 opened this issue Sep 17, 2023 · 13 comments

Comments

@TommyX12
Copy link

TommyX12 commented Sep 17, 2023

Describe the bug
In the latest release version of vscode vim, when I type in insert mode, about 50% of the time one or more of the characters I input will be missing. The problem is worse when there are heavy auto-complete or github copilot completions. Reverting to 1.25.2 solves this issue.

To Reproduce

  1. Open a file (preferably within an existing project).
  2. Go to insert mode, very quickly type "asdfghjk".
  3. Notice that some of the characters are missing.

Expected behavior
The typed string should always be "asdfghjk".

Environment:

  • Extension (VsCodeVim) version: 1.26.0
  • VSCode version: 1.82.2
  • OS: Windows 10
@nikitavoloboev
Copy link

nikitavoloboev commented Sep 18, 2023

This is incredibly frustrating. Please fix this.

pqrs-org/Karabiner-Elements#3595

Hitting the issue above, I can't automate keypresses with latest version of extension on.

Downgrading to 1.25.2 does indeed solve this.

@dj-blake
Copy link

Same issue. Really frustrating as it drops key presses quite frequently.

Note I don't use co-pilot, so it is not specifically due to interaction with that extension, though it does occur particularly when Intellisense is popping up suggestions.

Downgraded to 1.25.2 as well to avoid the issue.

@hawkinsw
Copy link

I want to say that I, too, am experiencing this issue. While it is frustrating, I completely understand that you are all doing the best that you can to make this incredibly awesome tool for the community and doing it in your free time. Thank you all for the work that you do!

@nachomglz
Copy link

Please fix this, when you type fast it drops like 30% of the characters, it's really frustrating.

@darrenchurchill
Copy link

darrenchurchill commented Sep 20, 2023

Update: This doesn't really fix the issue.

It probably wouldn't be an ideal solution, but as a workaround have you tried enabling the experimental VS Code affinity setting for this extension? It allows the extension to run in a dedicated host process, and may have solved or at least mitigated the problem for me.

See PR #8424 and Issue #7606

In settings.json:

"extensions.experimental.affinity": {
    "vscodevim.vim": 1
}

Instructions here to confirm the setting is enabled.

@darrenchurchill
Copy link

It looks like the issue is from 50bc4fe.

I'm not familiar with the code at all, but I set up a macro on my keyboard to rapidly output the string "asdfghjkl asdfghjkl ", and ran the extension various times during a git bisect. After removing the TaskQueue, the extension seems capable of losing track of the order keys were pressed in, missing keypresses, and even generating duplicate keypresses.

I hope this is helpful, I attached a couple screencasts of bad and good behavior.

vscodevimbad.mov
vscodevimgood.mov

@clauderoy790
Copy link

I can attest to this as well. I work on a Macbook Pro 2017 that is getting slow and before 1.26 I never had that problem but with 1.26 not only some characters will be missing, but it will add repeats and will mess up the order of the characters that I typed, it makes the extension completely unusable for me but using 1.25.2 solves everything for me.

@cTurnerEnvAU
Copy link

I had raised this separately as #8611 but I'm pretty sure this is the same issue so I'm just gonna drop the key details in as a comment.

When in insert mode, keystrokes following dual function keys (eg. https://github.com/qmk/qmk_firmware/blob/master/docs/tap_hold.md) are not being registered. I use an ergodox EZ with home row modifier keys: holding s/l yields ctrl, d/k alt and f/j the windows/meta key. This leads to typos such as form -> frm, site -> ste, etc.

  • Unlike other cases of this issue here, this only appeared to occur directly after modifier keys. Hopefully this might be useful information to someone with a good understanding of how QMK firmware sends keystrokes.

Rolling back vscodevim to version 1.25.2 resolves the issue.

@GaurangTandon
Copy link

Can we please at least rollback this version, until the fix is deployed? I have had this issue for close to 2 weeks, and all this while, I thought Create React App is causing VS Code to slow down 😃 There might be many more users with the same idea as me, still stuck on the latest version.

@Beatusvir
Copy link

I'm also having this issue, reverted to previous as mentioned in here fixes it.

@dycw
Copy link

dycw commented Sep 30, 2023

I can attest to this. This is extremely frustrating.

@graynode
Copy link

graynode commented Oct 3, 2023

I'm also having this same problem. I'm seeing the issue just like @cTurnerEnvAU is on my zsa keyboard.

@Testare
Copy link

Testare commented Oct 8, 2023

Is this fix live? I see 1.26.1 in the changelog as being live since 25 September, but there's no git tag and I can't install it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests