Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sync editor.wordSeparators and vim.iskeyword. closes #3166 #3305

Merged
merged 2 commits into from
Dec 30, 2018

Conversation

jpoon
Copy link
Member

@jpoon jpoon commented Dec 30, 2018

What this PR does / why we need it:

  • Adds iskeyword as an overlap setting to editor.wordSeparators. As a result, the following will take precedence:
  1. vim.iskeyword
  2. if (1) is undefined, editor.wordSeparators
  3. if (2) is undefined, then default value of @,48-57,_,128-167,224-235 is used
  • This change removes the default value for iskeyword so unless users have explicitly configured this value, editor.wordSeparators will be used.

So in the standard use case where users were using the default values for iskeyword those folks will be moving from using this:

/\()\"':,.;<>~!@#$%^&*|+=[]{}`?-

to vscode's default for editor.wordSeparators

`~!@#$%^&*()-=+[{]}\|;:'",.<>/?

The two are the same set, but in different order so there should not be a change in behaviour. Note that if vim.iskeyword is set, it will override the value of editor.wordSeparators.

Which issue(s) this PR fixes
#3166

Special notes for your reviewer:

@jpoon
Copy link
Member Author

jpoon commented Dec 30, 2018

Removing the breaking-change label as looking at the two sets, they are the exact same, just in different orders so we are good here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant