[p, [p, gp and gP #412

rebornix · 2016-07-08T11:25:40Z

Yay! We love PRs! 🎊

Please include a description of your change & check your PR against this list, thanks:

Commit message has a short title & issue references
Commits are squashed
It builds and tests pass (e.g gulp tslint)

Fix p/P cursor position is wrong #407.
Support [p, [p, gp and gP and have all features covered with test cases.

johnfn · 2016-07-12T18:29:52Z

src/textEditor.ts

@@ -107,5 +107,54 @@ export class TextEditor {
    static isLastLine(position : vscode.Position): boolean {
        return position.line === (vscode.window.activeTextEditor.document.lineCount - 1);
    }
+
+    static getLeftIndentation(line: string): number {


You can just name this getIndentationLevel

rebornix · 2016-07-13T02:19:54Z

Adjust the code except the findFirstNonWhitespace, not quire sure what's the best place to put it yet.

johnfn · 2016-07-13T19:19:21Z

LGTM 👍

rebornix added 2 commits July 8, 2016 15:40

Fix VSCodeVim#407.

9032803

[p, ]p, gp, gP and test cases.

6a9f912

Fix VSCodeVim#403.

johnfn reviewed Jul 12, 2016
View reviewed changes

Renaming

81643d1

johnfn merged commit 1a8533c into VSCodeVim:master Jul 13, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[p, [p, gp and gP #412

[p, [p, gp and gP #412

rebornix commented Jul 8, 2016

johnfn Jul 12, 2016 •

edited

Loading

rebornix commented Jul 13, 2016

johnfn commented Jul 13, 2016

[p, [p, gp and gP #412

[p, [p, gp and gP #412

Conversation

rebornix commented Jul 8, 2016

johnfn Jul 12, 2016 • edited Loading

Choose a reason for hiding this comment

rebornix commented Jul 13, 2016

johnfn commented Jul 13, 2016

johnfn Jul 12, 2016 •

edited

Loading