Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major upgrade #110

Draft
wants to merge 66 commits into
base: main
Choose a base branch
from
Draft

Major upgrade #110

wants to merge 66 commits into from

Conversation

Kipjr
Copy link
Member

@Kipjr Kipjr commented Dec 10, 2023

No description provided.

Copy link
Contributor

@Jannyboy313 Jannyboy313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waarom zijn er 3 workflows aangemaakt, heeft dit met lokaal test en prod te maken, want dan is het handig die namen te geven.?

  • Docker publish
  • Laravel
  • Sail publish

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
app/Exceptions/Handler.php Show resolved Hide resolved
app/Helpers/MSGraphAPI/User.php Show resolved Hide resolved
docs/DOCKER.md Show resolved Hide resolved
docs/DOCKER.md Show resolved Hide resolved
tests/Feature/BaseURLRequestTest.php Outdated Show resolved Hide resolved
@Kipjr
Copy link
Member Author

Kipjr commented Dec 11, 2023

Waarom zijn er 3 workflows aangemaakt, heeft dit met lokaal test en prod te maken, want dan is het handig die namen te geven.?

* Docker publish

* Laravel

* Sail publish

Laravel is het testen van de applicatie

Sail publish & docker publish zijn hetzelfde, denk ik

@Jannyboy313
Copy link
Contributor

Waarom zijn er 3 workflows aangemaakt, heeft dit met lokaal test en prod te maken, want dan is het handig die namen te geven.?

* Docker publish

* Laravel

* Sail publish

Laravel is het testen van de applicatie

Sail publish & docker publish zijn hetzelfde, denk ik

Als het hetzelfde is een van de twee eruit halen, of in ieder geval duidelijke naam van de action die het doet.

@Kipjr Kipjr marked this pull request as draft January 20, 2024 12:32
@Jannyboy313 Jannyboy313 mentioned this pull request Jan 22, 2024
Kipjr added a commit that referenced this pull request Jan 27, 2024
Kipjr added a commit that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants