Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify is_bad_qa to actually find bad qa #72

Merged
merged 1 commit into from
May 24, 2016
Merged

Modify is_bad_qa to actually find bad qa #72

merged 1 commit into from
May 24, 2016

Conversation

bud42
Copy link
Member

@bud42 bud42 commented May 16, 2016 •
edited
Loading

resolve #68

@bud42 bud42 mentioned this pull request May 16, 2016
Closed
@bud42
Copy link
Member Author

bud42 commented May 23, 2016

@byvernault any thoughts?

@byvernault
Copy link
Contributor

I will check tomorrow.

Ben

On May 23, 2016, at 20:40, Brian D. Boyd notifications@github.com wrote:

@byvernault any thoughts?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@byvernault
Copy link
Contributor

byvernault commented May 24, 2016 •
edited
Loading

I don't have any jobs yet using the QA of other jobs so I can't really test it. Did you get a chance to give it a try?

It looks good to me. It should do the job.

@damonms
Copy link
Contributor

damonms commented May 24, 2016

Works for the errors I had.

@damonms damonms closed this May 24, 2016
@damonms damonms reopened this May 24, 2016
@damonms damonms merged commit 8f1ca4e into master May 24, 2016
@damonms damonms deleted the fix_isbadqa branch May 24, 2016 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reproc and "Bad (Needs Edits)" show up as a good cassr
3 participants
@bud42 @byvernault @damonms