Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update:package #127

Merged
merged 23 commits into from
Feb 29, 2024
Merged

update:package #127

merged 23 commits into from
Feb 29, 2024

Conversation

Huzitatuguharu
Copy link
Contributor

@Huzitatuguharu Huzitatuguharu commented Dec 18, 2023 •
edited
Loading 

 "@typescript-eslint/no-explicit-any": "warn",
 "@typescript-eslint/no-unused-vars": "warn",
 "@typescript-eslint/await-thenable": "warn"

@Huzitatuguharu Huzitatuguharu marked this pull request as ready for review December 26, 2023 23:55
thashimoto1998
thashimoto1998 reviewed Dec 28, 2023
View reviewed changes
Copy link
Contributor

@thashimoto1998 thashimoto1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

マージ先をリリースブランチrelease-0.1.13にしてください。

src/vwbl/blockchain/erc1155/VWBLProtocol.ts Outdated Show resolved Hide resolved
src/vwbl/erc1155/VWBL.ts Outdated
const chainId =
"web3" in this.opts ? await this.opts.web3.eth.getChainId() : await this.opts.ethersSigner.getChainId();
const chainIdBigInt =
"web3" in this.opts ? await (this.opts.web3.eth as any).getChainId() : await this.opts.ethersSigner.getChainId();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(this.opts.web3.eth as any).getChainId()

any型にキャストしない場合どのエラーが出ました？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

このエラーが出ます

 error TS2345: Argument of type 'number | bigint' is not assignable to parameter of type 'number'.
  Type 'bigint' is not assignable to type 'number'.
Screenshot 2024-01-04 at 11 51 54

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Huzitatuguharu

test/large/vwbl/mintOnGoerli.test.ts Outdated
@@ -25,7 +24,7 @@ const hdWalletProvider = new HDWalletProvider({
privateKeys: [process.env.PRIVATE_KEY as string],
providerOrUrl: providerUrl
})
const web3 = new Web3(hdWalletProvider as provider);
const web3 = new Web3(hdWalletProvider as any);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any型にキャストしない場合どのエラーが出ました？

@Huzitatuguharu Huzitatuguharu changed the base branch from master to release-0.1.13 January 4, 2024 07:19
thashimoto1998
thashimoto1998 approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@thashimoto1998 thashimoto1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2点as anyの箇所があったので削除してマージお願いします。

src/vwbl/erc1155/VWBL.ts Outdated
const chainId =
"web3" in this.opts ? await this.opts.web3.eth.getChainId() : await this.opts.ethersSigner.getChainId();
const chainIdBigInt =
"web3" in this.opts ? await (this.opts.web3.eth as any).getChainId() : await this.opts.ethersSigner.getChainId();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as anyを削除してください

src/vwbl/erc1155/VWBL.ts Outdated
const chainId =
"web3" in this.opts ? await this.opts.web3.eth.getChainId() : await this.opts.ethersSigner.getChainId();
const chainIdBigInt =
"web3" in this.opts ? await (this.opts.web3.eth as any).getChainId() : await this.opts.ethersSigner.getChainId();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as anyを削除してください

@Huzitatuguharu Huzitatuguharu merged commit 63ca8c5 into release-0.1.13 Feb 29, 2024
1 check passed
@Huzitatuguharu Huzitatuguharu deleted the feature/update-web3js branch February 29, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thashimoto1998 thashimoto1998 thashimoto1998 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Huzitatuguharu @thashimoto1998 @seki-seki