Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/add functions and comments #150

Merged
merged 9 commits into from
Jun 13, 2024
Merged

Fix/add functions and comments #150

merged 9 commits into from
Jun 13, 2024

Conversation

Huzitatuguharu
Copy link
Contributor

@Huzitatuguharu Huzitatuguharu commented Jun 12, 2024 •
edited
Loading

  • 不要なコード削除
  • テストコードの修正
  • ManagedCreateTokenForIPFS
    const encryptedContent の関数を修正
  • env.templateをPinataに変更

@Huzitatuguharu Huzitatuguharu changed the base branch from master to release-0.1.19 June 12, 2024 07:15
@thashimoto1998
Copy link
Contributor

@Huzitatuguharu
UPLOAD_CONTENのstep処理が2回行われているので1回に修正してください。

VWBL-SDK/src/vwbl/erc6150/VWBLMetaTx.ts

Line 226 in 7e7e921

subscriber?.kickStep(StepStatus.UPLOAD_CONTENT);

@Huzitatuguharu Huzitatuguharu marked this pull request as ready for review June 12, 2024 13:05
@thashimoto1998
Copy link
Contributor

thashimoto1998 commented Jun 12, 2024 •
edited
Loading

VWBLERC1155, VWBLERC1155EthersのクラスにmintTokenForIPFSのメソッド追加をお願いします。
https://github.com/VWBL/VWBL-SDK/blob/fix/add-functions-and-comments/src/vwbl/erc721/VWBL.ts#L380

thashimoto1998 added a commit that referenced this pull request Jun 12, 2024
@thashimoto1998
feat: marge pr #148 & #150
cf8303f
thashimoto1998
thashimoto1998 approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@thashimoto1998 thashimoto1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Huzitatuguharu Huzitatuguharu merged commit e951f7a into release-0.1.19 Jun 13, 2024
1 check passed
@Huzitatuguharu Huzitatuguharu deleted the fix/add-functions-and-comments branch June 13, 2024 05:37
@Huzitatuguharu Huzitatuguharu mentioned this pull request Jun 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thashimoto1998 thashimoto1998 thashimoto1998 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Huzitatuguharu @thashimoto1998