Feat/impl erc1155 #70
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
posaune0423
requested review from
seki-seki and
thashimoto1998
and removed request for
seki-seki
|
すみません、ちょっと差分見づらくなってしまったんですがこちらお手隙でレビューいただけると幸いです 🙇🏻 |
seki-seki
previously approved these changes
Oct 17, 2022
|
コンフリクトの解消をおねがいします |
|
このPRの修正も包含した別のPRで実装続けるのでcloseします |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ERC1155対応
概要
rarible sdkのようにERC規格の差をどこのレイヤーで吸収させるかとか、もっとうまく共通化・抽象化する方法ありそうだけどあまり大きな変更を入れるとドキュメントを書き直したりだとか後方互換性もあるので一旦
VWBLインスタンスとは別にVWBLERC1155インスタンスを生成する方法を取りました。ついでにテストの修正、CIの追加も行いました。
コントラクト側の修正 => VWBL/VWBL-protocol#67
対応内容
VWBLBaseクラスとしてbase.tsに実装/erc721/*)