Get sign from server #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seki-seki
commented
Mar 1, 2023
Comment on lines
+59
to
+61
| const castedSigner = signer as any; | ||
| // eslint-disable-next-line | ||
| const chainId = castedSigner.hasOwnProperty("eth") |
There was a problem hiding this comment.
signer instanceof Web3 でうまく動かなかったので暫定的にこれ
signerの型を調べるロジックを切り出す必要がある
posaune0423
previously approved these changes
Mar 5, 2023
| @@ -228,10 +230,11 @@ export class VWBLNFTMetaTx { | |||
| batchNonce, | |||
| data | |||
| ); | |||
| console.log("se"); | |||
There was a problem hiding this comment.
確認ですがこのseとreというログ出力は意図的なものであってますかね？もしそうなら問題ないです〜
|
approveですが一点だけコメントしました！ |
delete console log
|
以下を追加実装
|
|
以下を追加実装
|
seki-seki
commented
Mar 10, 2023
| const address = await this._getAddressBySigner(signer); | ||
| const signatureString = await this.api | ||
| .getSignatureString(this.contractAddress, chainId, address) | ||
| .catch(() => MESSAGE_TO_BE_SIGNED); |
There was a problem hiding this comment.
if(this.signMsg === signatureString) return
|
以下を追加実装
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.