Improved way of injecting css + some refactoring #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 3, 2018
Merged
|
@malinushj looks great, thank you! i am not happy with formatting though, i think i'll introduce automatic solution in the upcoming release |
|
Yea, sorry about that, formatting was done by Prettier, left it enabled in vscode 😅
… On 17 Mar 2018, at 15:51, Valentyn ***@***.***> wrote:
@malinushj <https://github.com/malinushj> looks great, thank you!
i am not happy with formatting though, i think i'll introduce automatic solution in the upcoming release
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#60 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AVmJf69WpdL9lebRXQnF8uu9aUMvbpy3ks5tfRTxgaJpZM4SarAq>.
|
This was referenced Mar 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Biggest visible change in this PR is the fact that browsersync now reloads/injects only the changed css files.
Other than that, I've refactored the plugin to an ES6 class, since we've switched to that, and also the css emission file.
All formatting and other changes were made by Prettier.
This PR was fragmented from my update to webpack 4 (which is coming up in the next PR), decided it's best to separate them since it might be a good addition.
Let me know what you think @Va1 .