Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor of datautils #20

Closed
wants to merge 5 commits into from
Closed

refactor of datautils #20

wants to merge 5 commits into from

Conversation

poedator
Copy link
Collaborator

@poedator poedator commented Jul 1, 2023

  • fixing bos, eos token ids when loading from decapoda-research llama models - this was cause by incorrect tokenized config and was causing errors with transformers >=4.29.0
  • combining old and new eval functions
  • separate loading of train and eval data using param:eval_mode (saves time)
  • combining args.dataset and args.custom_data_path into one option
  • loading parama and refinedweb using dataset option (since they both are included into this repo in a fixed location)
    tests available in the private chat

Godofnothing
Godofnothing reviewed Jul 1, 2023
View reviewed changes
datautils.py Outdated Show resolved Hide resolved
poedator
poedator commented Jul 3, 2023
View reviewed changes
lmeval.py
@@ -125,7 +124,7 @@ def main():
num_fewshot=args.num_fewshot,
batch_size=args.batch_size,
device=args.device,
no_cache=args.no_cache,
no_cache=True,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no_cache is recommended to be set true in the tests. Also no_cache=False is not compatible with evaluating pre-loaded models (incorrect code in lm-eval). Now it is set to True by default for convenience, option removed.

@Vahe1994 Vahe1994 mentioned this pull request Jul 17, 2023
Open
@poedator poedator mentioned this pull request Jul 21, 2023
Merged
@poedator
Copy link
Collaborator Author

reworked in #29

@poedator poedator closed this Jul 21, 2023
@poedator poedator deleted the datautils_upd branch August 5, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Godofnothing Godofnothing Godofnothing left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@poedator @Godofnothing