Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added automatic style check #35

Merged
merged 5 commits into from
Sep 7, 2023
Merged

Added automatic style check #35

merged 5 commits into from
Sep 7, 2023

Conversation

Vahe1994
Copy link
Owner

@Vahe1994 Vahe1994 commented Sep 4, 2023

  • Added automatic style check with black and isort
  • With a permission, code was taken from hivemind and petals projects

@Vahe1994 Vahe1994 marked this pull request as ready for review September 4, 2023 12:31
Copy link
Collaborator

@Godofnothing Godofnothing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks fine, but thereare many meaningless changes - i.e permutations of import order, what does it bring?

@Vahe1994
Copy link
Owner Author

Vahe1994 commented Sep 4, 2023

Overall looks fine, but thereare many meaningless changes - i.e permutations of import order, what does it bring?

This is due to isort library isort is a Python library to sort imports alphabetically and automatically separated into sections and by type. . You can look here for more information why this is good idea to use.

@poedator
Copy link
Collaborator

poedator commented Sep 4, 2023

I propose not to apply changes to the contrib files from LM-Eval harness. This is to be able to make an easy claim that we did not tinker with that testing code.

@Vahe1994
Copy link
Owner Author

Vahe1994 commented Sep 6, 2023

I propose not to apply changes to the contrib files from LM-Eval harness. This is to be able to make an easy claim that we did not tinker with that testing code.

Good point. Excluded LM-eval-harness folder from isort and black.

@Vahe1994 Vahe1994 merged commit 8a5907b into main Sep 7, 2023
2 checks passed
@Vahe1994 Vahe1994 deleted the auto_style_check branch September 7, 2023 09:05
@Vahe1994 Vahe1994 restored the auto_style_check branch September 7, 2023 09:06
Vahe1994 added a commit that referenced this pull request Sep 7, 2023
Vahe1994 added a commit that referenced this pull request Sep 7, 2023
@Vahe1994 Vahe1994 mentioned this pull request Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants