-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added automatic style check #35
Conversation
Vahe1994
commented
Sep 4, 2023
•
edited
Loading
edited
- Added automatic style check with black and isort
- With a permission, code was taken from hivemind and petals projects
2. Automatic check black and isort
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks fine, but thereare many meaningless changes - i.e permutations of import order, what does it bring?
This is due to isort library isort is a Python library to sort imports alphabetically and automatically separated into sections and by type. . You can look here for more information why this is good idea to use. |
I propose not to apply changes to the contrib files from LM-Eval harness. This is to be able to make an easy claim that we did not tinker with that testing code. |
This reverts commit 080205d.
Good point. Excluded LM-eval-harness folder from isort and black. |