Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change tslib version constraint from 2.0.1 to ^2.0.1 #536

Merged
merged 1 commit into from
May 2, 2024

Conversation

aqeelat
Copy link
Contributor

@aqeelat aqeelat commented May 2, 2024

resolves #534

Copy link

codesandbox-ci bot commented May 2, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@aqeelat
Copy link
Contributor Author

aqeelat commented May 2, 2024

@ValentinH there was a warning when I ran yarn start
It's not related to my PR but I thought I'd let you know

12:29:11 PM [vite] warning: 
react-easy-crop/src/Cropper.tsx
13 |    clamp
14 |  } from "./helpers";
15 |  import cssStyles from "./styles.css";
   |                         ^
16 |  const MIN_ZOOM = 1;
17 |  const MAX_ZOOM = 3;
Default and named imports from CSS files are deprecated. Use the ?inline query instead. For example: import cssStyles from "./styles.css?inline"
  Plugin: vite:import-analysis
  File: react-easy-crop/src/Cropper.tsx

@ValentinH
Copy link
Owner

I'm unfortunately aware of this and I actually tried updating to the latest Vite but it was quite complex.

This way of importing the CSS is the reason why the current packaging logic is hard to update 😢

@ValentinH ValentinH added the patch Increment the patch version when merged label May 2, 2024
@ValentinH ValentinH merged commit 21f41a3 into ValentinH:main May 2, 2024
4 checks passed
Copy link

github-actions bot commented May 6, 2024

🚀 PR was released in v5.0.7 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow lenient dependency on tslib
2 participants