Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glslang should be a git submodule #29

Open
flukejones opened this issue Aug 22, 2018 · 8 comments
Open

glslang should be a git submodule #29

flukejones opened this issue Aug 22, 2018 · 8 comments

Comments

@flukejones
Copy link

flukejones commented Aug 22, 2018

I notice that glslangValidator is precompiled - this should probably be a git submodule to allow for easier building on macOS (and other Linux distros).

@cjwijtmans
Copy link

i agree. i was wondering why this is not a submodule.

@peterson432
Copy link

yea, glslang validator is pre-compiled and it creates a difficulty for building an mac OS and linux, it should be a submodule for easier access.

@jbmagination
Copy link

Just a note, two years in the future: macOS is not a Linux distro. It is a Unix-based operating system, while Linux is a Unix-based kernel. macOS does not run Linux, it runs Unix.

@flukejones
Copy link
Author

Just a note, two years in the future: macOS is not a Linux distro. It is a Unix-based operating system, while Linux is a Unix-based kernel. macOS does not run Linux, it runs Unix.

What was the point of this reply other than to be correct? The initial issue post was a mistype and everyone else seemed to get the point.

@cjwijtmans
Copy link

Just a note, two years in the future: macOS is not a Linux distro. It is a Unix-based operating system, while Linux is a Unix-based kernel. macOS does not run Linux, it runs Unix.

(L)inux (I)s (N)ot (U)ni(X)

@flukejones
Copy link
Author

Christ...
unsubscribe

@jbmagination
Copy link

The point was so that people could be informed, I'm sure someone out there probably might assume that. Yeah, likely a good idea to unsubscribe. Sorry!

@cjwijtmans
Copy link

The point was so that people could be informed, I'm sure someone out there probably might assume that. Yeah, likely a good idea to unsubscribe. Sorry!

Except you are totally incorrect but ok.

Maykin-99 pushed a commit to Maykin-99/Proton that referenced this issue May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants