Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a fake implementation of POWRPROF.dll.PowerSettingRegisterNotification for compatibility with Special K mods #5625

Open
Kaldaien opened this issue Feb 26, 2022 · 2 comments

Comments

@Kaldaien
Copy link

Special K has a lot of integration with power management on Windows to help with low-end systems. It has been a part of Special K for many years, so there are versions of Special K used in mods 5+ years old at this point that require this API.

I cannot go back and retroactively add compat hacks into all my old mods to make them work with WINE, so I really need the compat hack burden to be placed on Proton's shoulders. Newer versions actually detect WINE and start to disable these features, but I need Proton to do some of the work to make Tales of Vesperia Fix, etc. compatible with SteamDeck.

As I understand things, WINE doesn't implement much of any of the power management APIs in Windows, so there should be absolutely no harm in implementing a stub that just lies to my software and claims to have registered a notification.

@Kaldaien
Copy link
Author

In fact... Special K can handle an unsuccessful notification registration, so maybe do that? Anything's better than aborting the entire game because of an API call that isn't implemented.

@aeikum
Copy link
Collaborator

aeikum commented Feb 28, 2022

I don't know that we'll have time to do this ourselves any time soon, but we'd welcome patches if you'd like to take a stab at it yourself. They could go upstream first, and then we can pick them back into Proton's Wine.

pull bot pushed a commit to Mu-L/wine that referenced this issue Mar 2, 2022
Needed by old Special K versions according to
ValveSoftware/Proton#5625.

Signed-off-by: Torge Matthies <openglfreak@googlemail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants