Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion '!modifiers.empty()' when running gamescope in embedded mode #1215

Open
Erfboom opened this issue Mar 26, 2024 · 9 comments
Open

Comments

@Erfboom
Copy link

Erfboom commented Mar 26, 2024

Using the following:

  • Intel UHD630
  • 6.8.1-1-default linux kernel
  • Opensuse Tumbleweed
  • gamescope -W 2560 -H 1440 -r 120 -- moonlight in tty2 (embedded)

I receive Assertion '!modifiers.empty()' after a core dump. The program can be anything, not just moonlight.

When I run gamescope in nested mode, I can run things, but for moonlight specifically, once I activate a stream, I'll see a black frame in between every couple of good frames. If I use --expose-wayland, this will be reduced, but I'll trade it for choppiness in the stream on the native moonlight-qt, or smoothness with the AppImage variant but still the black frames.

If I run moonlight from terminal, no gamescope, the stream is as intended, smooth, no black frames.

EDIT: The flickering was caused by specifying the refresh rate in the gamescope command. Removing it causes the stream to be fine.

rosefromthedead added a commit to rosefromthedead/gamescope that referenced this issue Apr 4, 2024
DRMFormatToVulkan is lossy; it doesn't distinguish between e.g. XR30 and
AR30. The primary plane on my laptop (8086:5917) supports XR30 but not
AR30, so when we get mixed up and try to use AR30 it fails and we crash.
Deal in DRM formats instead to avoid having to carry around an extra
hasAlpha flag.

Fixes ValveSoftware#1215, but we still crash on my laptop for other reasons, so it
looks like Intel needs more fixes.
@rien
Copy link

rien commented Jul 25, 2024

I'm encountering a segfault as well on an Intel UHD620 - @Erfboom did you manage to work around this issue?

rien pushed a commit to rien/gamescope that referenced this issue Jul 25, 2024
DRMFormatToVulkan is lossy; it doesn't distinguish between e.g. XR30 and
AR30. The primary plane on my laptop (8086:5917) supports XR30 but not
AR30, so when we get mixed up and try to use AR30 it fails and we crash.
Deal in DRM formats instead to avoid having to carry around an extra
hasAlpha flag.

Fixes ValveSoftware#1215, but we still crash on my laptop for other reasons, so it
looks like Intel needs more fixes.
@Erfboom
Copy link
Author

Erfboom commented Jul 25, 2024

No, but I believe it's being worked on.

@jpgrego
Copy link

jpgrego commented Aug 26, 2024

Same problem here, also with a HD620. Any news regarding this?

@repomansez
Copy link

repomansez commented Aug 29, 2024

Happening to me too, even when just launching gamescope by itself. UHD Graphics 620 on a ThinkPad T480

@2goodAP
Copy link

2goodAP commented Sep 7, 2024

Yes, I too can reproduce this on NixOS with Intel GPU. I am using KDE Plasma 6.1.4. Also, the assertion failure only happens in nested mode. Everything works just fine for me under a separate tty.

I did some digging around and found this to be an issue for 3.15.x versions only. Nested mode works just fine for me up to commit 94271f3.

The 3.15.0 commit 28a4744, seems to have made some changes to DRM formats for composited outputs. That seems to be a possible cause for the assertion failure in nested mode only.

@asukaminato0721
Copy link

it also failed on

GPU: Intel Iris Xe Graphics @ 1.30 GHz [Integrated]

@repomansez
Copy link

Upgrading to 3.15.9 completely fixed the issue for me. @jpgrego @2goodAP @asukaminato0721 @Erfboom can you guys try to update and see if it works too? Gentoo and NixOS specifically are shipping an out of date version of Gamescope.

@2goodAP
Copy link

2goodAP commented Sep 20, 2024

Yeah 3.15.9 seems to have fixed it for me too. Thanks for the heads up @repomansez.

@asukaminato0721
Copy link

arch updated to

[gamescope] [Info]  console: gamescope version 3.15.11 (gcc 14.2.1)

and it fixed for me too. Thanks for the heads up @repomansez.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants