Improve build #55
Open
Improve build #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, update other meta-files to ensure they're limited to the right platforms.
|
FYI, I am pretty sure the ucrtbased files are not intended to be redistributable (at least other debug runtimes aren't) and they're not actually needed here (since we're building against the release CRT), so those could also be removed |
This was referenced Oct 5, 2020
CMake seems to not always copy (at least on Windows) if the file isn't removed first.
|
Not sure, suppose we could try to remove them and see what happens |
|
The binaries for Linux are still there, they just aren't located in two different places in the plugin. |
|
This absolutely fixed an issue I had, and I'm extremely grateful! I did have to enable LinuxStandalone64 on the assembly definition though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The peculiarities of the build threw me off: I kept getting errors, etc. and it seemed to only be supported as an "in-source" build which is unusual for CMake. I have adjusted things so that build dir and source dir don't have to be the same, the resulting binaries (and deps) can still be copied as a post-build step (optional, however, adjustable from CMake), and the script is otherwise simplified by using things built in to CMake and removing unneeded options. I did not touch CI or the README here.
Note: I was a bit confused by the fact that some Linux binaries are in a sub-sub directory.
so I put a TODO in the CMake for it. after further review, I'm pretty confident files were in there as an accident, since the RPATH wouldn't find them there, and they may conflict at build time, so I removed them.