Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winebus.sys: Fix container detection #139

Open
wants to merge 1 commit into
base: proton_7.0
Choose a base branch
from

Conversation

redmcg
Copy link
Contributor

@redmcg redmcg commented Feb 23, 2022

msvcrt 'access' will return 0 if the file is present and readable

msvcrt 'access' will return 0 if the file is present and readable
@ivyl
Copy link
Collaborator

ivyl commented Feb 23, 2022

Nice catch.

FWIW this is not msvcrt's access but glibc's one. The code lives on the unix side.

@redmcg
Copy link
Contributor Author

redmcg commented Feb 23, 2022

FWIW this is not msvcrt's access but glibc's one. The code lives on the unix side.

Oops, of course; not sure what I was thinking.

A question unrelated to this PR: is there a way to disable the container when launching a game in Proton? I was just searching the code to see if there was an env variable or something that could be set - but you might know off the top of your head.

@ivyl
Copy link
Collaborator

ivyl commented Feb 23, 2022

On Arch Linux there's a package named steam-native that install all the dependencies for Steam itself and runs things without the runtime:

$ cat $(which steam-native)
#!/bin/bash
export STEAM_RUNTIME=0
export STEAM_RUNTIME_HEAVY=0
# Workaround for dbus fatal termination related coredumps (SIGABRT)
# https://github.com/ValveSoftware/steam-for-linux/issues/4464
export DBUS_FATAL_WARNINGS=0
# Override some libraries as these are what games linked against.
export LD_LIBRARY_PATH="/usr/lib/steam:/usr/lib32/steam${LD_LIBRARY_PATH:+:}$LD_LIBRARY_PATH"
exec /usr/lib/steam/steam "$@"

It may do what you want. Just keep in mind that running Proton outside of the provided containers is unsupported.

@redmcg
Copy link
Contributor Author

redmcg commented Feb 23, 2022

Awesome - thanks for that - I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants