Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sign up with google #299

Closed
wants to merge 8 commits into from
Closed

feat: sign up with google #299

wants to merge 8 commits into from

Conversation

Vandivier
Copy link
Owner

closes #103
partials #151

Copy link

vercel bot commented Aug 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ladderly-3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 17, 2024 2:00pm

</svg>
</div>
<span className="gsi-material-button-contents">Sign in with Google</span>
<span style={{ display: 'none' }}>Sign in with Google</span>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to leave this here? 🙂

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey! good call out. this was intentional because Google includes it in the recommended markup, link below
but I have no idea why they do that! so i will try without it...

https://developers.google.com/identity/branding-guidelines

@Vandivier
Copy link
Owner Author

closing in favor of #303

@Vandivier Vandivier closed this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Social Sign in
2 participants