Recreating organizer dashboard pr #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| const KVData = (data: { [key: string]: number }): ChartData<ChartJSData> => { | ||
| const keys = Object.keys(data).slice(0, -1); | ||
| const values = Object.values(data).slice(0, -1); | ||
| const KVData = (hackerData: string[], types: string): ChartData<ChartJSData> => { |
There was a problem hiding this comment.
Function KVData has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
| @@ -218,17 +196,35 @@ export const OrganizerDash: FC<Props> = ({ disableAnimations }): JSX.Element => | |||
| <StyledFloatingPopupTop marginBottom="1rem" backgroundOpacity="1" padding="1.5rem"> | |||
| <UpperChartLayout> | |||
| <BarChartLayout> | |||
| <Bar data={KVData(data.getAllHackerStatuses)} options={statusOptions} /> | |||
| <Bar | |||
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
| Manage hackers | ||
| </Button> | ||
| </StyledFloatingPopupTop> | ||
| <StyledFloatingPopupBottom backgroundOpacity="1" padding="1.5rem"> | ||
| <Pie data={KVData(data.getAllHackerSizes)} options={shirtOptions} /> | ||
| <Pie data={KVData(data.getAllHackerGenders)} options={genderOptions} /> | ||
| <Pie |
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
| )} | ||
| options={shirtOptions} | ||
| /> | ||
| <Pie |
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
|
Code Climate has analyzed commit f7ff9ef and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 21.0% (0% is the threshold). This pull request will bring the total coverage in the repository to 62.9% (-0.3% change). View more on Code Climate. |
Closed
SamLee514
pushed a commit
that referenced
this pull request
Sep 28, 2021
* Recreating organizer dashboard pr * removing unnessary imports * attendingInPerson hasn't been merged into main yet * fix some compilation errors * correct organizer dashboard route Co-authored-by: Samuel Lee <samlee514@Samuels-MacBook-Pro-2.local>
SamLee514
pushed a commit
that referenced
this pull request
Sep 28, 2021
* Recreating organizer dashboard pr * removing unnessary imports * attendingInPerson hasn't been merged into main yet * fix some compilation errors * correct organizer dashboard route Co-authored-by: Samuel Lee <samlee514@Samuels-MacBook-Pro-2.local>
SamLee514
pushed a commit
that referenced
this pull request
Sep 28, 2021
* Recreating organizer dashboard pr * removing unnessary imports * attendingInPerson hasn't been merged into main yet * fix some compilation errors * correct organizer dashboard route Co-authored-by: Samuel Lee <samlee514@Samuels-MacBook-Pro-2.local>
SamLee514
pushed a commit
that referenced
this pull request
Sep 29, 2021
* Recreating organizer dashboard pr * removing unnessary imports * attendingInPerson hasn't been merged into main yet * fix some compilation errors * correct organizer dashboard route Co-authored-by: Samuel Lee <samlee514@Samuels-MacBook-Pro-2.local>
SamLee514
pushed a commit
that referenced
this pull request
Sep 30, 2021
* Recreating organizer dashboard pr * removing unnessary imports * attendingInPerson hasn't been merged into main yet * fix some compilation errors * correct organizer dashboard route Co-authored-by: Samuel Lee <samlee514@Samuels-MacBook-Pro-2.local>
SamLee514
pushed a commit
that referenced
this pull request
Oct 4, 2021
* Recreating organizer dashboard pr * removing unnessary imports * attendingInPerson hasn't been merged into main yet * fix some compilation errors * correct organizer dashboard route Co-authored-by: Samuel Lee <samlee514@Samuels-MacBook-Pro-2.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The organizer dash no longer throws an error. Instead, useful charts about cumulative t-shirt sizes, application status, and gender are shown.
Review Focus
Anything you want the reviewer to pay attention to? Feel free to delete this section.