Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file upload limit, toast error for breaking that limit, loading spinner #851

Merged
merged 2 commits into from
Sep 26, 2021

Conversation

SamLee514
Copy link
Contributor

Summary

Adds a file upload limit to resume upload. Also little spin spin.

Review Focus

Anything you want the reviewer to pay attention to? Feel free to delete this section.

@codeclimate
Copy link

codeclimate bot commented Sep 26, 2021

Code Climate has analyzed commit 7c35d48 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 33.3% (0% is the threshold).

This pull request will bring the total coverage in the repository to 63.2% (0.0% change).

View more on Code Climate.

@aadibajpai aadibajpai merged commit add80a6 into main Sep 26, 2021
@aadibajpai aadibajpai deleted the resume-upload branch September 26, 2021 20:59
@github-actions github-actions bot added the approved Automatically added, do not manually add label Sep 26, 2021
SamLee514 added a commit that referenced this pull request Sep 28, 2021
…er (#851)

* file upload limit, toast error for breaking that limit, loading spinner

* lint

Co-authored-by: Samuel Lee <samlee514@Samuels-MacBook-Pro-2.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Automatically added, do not manually add
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants