Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N60 #859

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

N60 #859

wants to merge 5 commits into from

Conversation

Chinchuluun1029
Copy link
Contributor

Summary

  • Changing the previous error messages to toast
  • Added success messages to toast also
  • Change button texts for better differentiation
  • Resets textfields and select > options after creating

P.S. Had to access the 'select' elements with refs, forgive me for I have sinned (to reset to the disabled default value)

On success:
image

On error:
image

@codeclimate
Copy link

codeclimate bot commented Sep 29, 2021

Code Climate has analyzed commit 006862b and detected 5 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1
Duplication 4

The test coverage on the diff in this pull request is 28.9% (0% is the threshold).

This pull request will bring the total coverage in the repository to 62.0% (-0.2% change).

View more on Code Climate.

Copy link
Contributor

@SamLee514 SamLee514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, everything works correctly. Could you just address the linting issues? Causing a build failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants