Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup tests for new error messages #28

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Fixup tests for new error messages #28

merged 1 commit into from
Apr 20, 2022

Conversation

fhcarter
Copy link
Contributor

Adds services to list of things allowed... No change in product -- test only.

@fhcarter fhcarter self-assigned this Apr 20, 2022
Copy link
Contributor

@steve-langley steve-langley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks Fred!

@rblumer4
Copy link
Contributor

rblumer4 commented Apr 20, 2022

@steve-langley, @fhcarter, can one of you add a test case for service publishes, too?
e.g. can perform a publish on service testPublishService()

then we probably need the same changes to the Node SDK...

@fhcarter
Copy link
Contributor Author

@steve-langley, @fhcarter, can one of you add a test case for service publishes, too? e.g. can perform a publish on service testPublishService()

then we probably need the same changes to the Node SDK...

This is now issue #29

@fhcarter fhcarter merged commit bc8c8d9 into master Apr 20, 2022
@fhcarter fhcarter deleted the fhc-fixTestErrors branch April 20, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants