Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proper support for light themes #10

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Add proper support for light themes #10

merged 2 commits into from
Feb 19, 2024

Conversation

freyacodes
Copy link
Contributor

  • The log and the main menu now uses consistent black/white colors when selected, depending on the theme
  • The white part of the title now uses the ANSI color for white, which is theme dependent

Resolves #9

@freyacodes
Use ANSI white color in Skrive title
a03d0e6
@freyacodes
Use adaptive colors for list options
c28569b 
Also make the colors consistent between the log and main menu
@VanuPhantom VanuPhantom added the enhancement New feature or request label Feb 19, 2024
@VanuPhantom VanuPhantom self-requested a review February 19, 2024 09:24
VanuPhantom
VanuPhantom approved these changes Feb 19, 2024
View reviewed changes
Copy link
Owner

@VanuPhantom VanuPhantom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Good job :)

@VanuPhantom VanuPhantom merged commit a5b0575 into VanuPhantom:main Feb 19, 2024
@freyacodes freyacodes deleted the light-mode-fixes branch February 19, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VanuPhantom VanuPhantom VanuPhantom approved these changes

Assignees

@freyacodes freyacodes

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The app's white colours do not work correctly in light mode
2 participants
@freyacodes @VanuPhantom