Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui of retina is edited (still to be done)and few templates cornea(prathyusha) are added #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

8wgf3b
Copy link

@8wgf3b 8wgf3b commented Jun 7, 2017

No description provided.

@VarunWachaspati
Copy link
Owner

Great to see a PR. Here are a few pointers from my side =

  1. Always break your commits into small functional units. One large commit should at all cost be avoided as it would make it difficult for the maintainer of the repository the intention behind the commit and how it actually accomplishes it
  2. Your commit messages should be crystal clear on what they are trying to accomplish and should mention only what it has accomplished. No Work-In-Progress should be cited.
  3. All new features should be added on to a newly created branch and PRs would be accepted to the main branch only after complete testing, as it is intended to be a stable release branch. No Work-in-Progress should be committed to main branch.

You could refer my commit history in this repository but even that is not good reference, I would like you to go through some good open source projects to understand the nuances of commits.

Here is a link from Linus Torvalds on how to write good commit messages

Kindly make another PR after you adhere to the above stated

@8wgf3b
Copy link
Author

8wgf3b commented Jun 9, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants