[IMP] cfdilib: Removed automatic NA assignation to empty values
#74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CFDI 3.3 have a extensive catalog, then when is validated the xsd all the attributes are validated that the value assigned is found in the catalogs. Before of this change, if the attribute in the dict values was empty, this was updated to set NA, but in CFDI 3.3, is validated that the value exist in the catalog, and take many time in compare the value. Example in the attribute 'ClaveProdServ' that have 52828 records. Now, if the value is empty only not add the attribute and do not take many time because only validate that the attribute is not found. Why not only add a validation like `if attribute '!=' 'NA'`, because the catalog to Unit Codes have the record `NA - Miligramo por kilogramo` and We could ignore that value.
luistorresm
force-pushed
the
master-no-NA-luist
branch
from
150211d
to
54c0632
Compare
|
Could you merge this PR, please? Regards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CFDI 3.3 have a extensive catalog, then when is validated the xsd all
the attributes are validated that the value assigned is found in the
catalogs.
Before of this change, if the attribute in the dict values was
empty, this was updated to set NA, but in CFDI 3.3, is validated that
the value exist in the catalog, and take many time in compare the value.
Example in the attribute 'ClaveProdServ' that have 52828 records.
Now, if the value is empty only not add the attribute and do not take
many time because only validate that the attribute is not found.
Why not only add a validation like
if attribute '!=' 'NA', because thecatalog to Unit Codes have the record
NA - Miligramo por kilogramoandWe could ignore that value.
Here a time:
