Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD][ifrs_report] TASK#3157,ISSUE#558 #32

Merged
merged 3 commits into from
Apr 20, 2015

Conversation

hugho-ad
Copy link
Contributor

This pr modify the module ifrs_report for grand permisson to Auditor group created in account_group_auditory in addon-vauxo

@@ -33,6 +33,7 @@
"depends": [
"base",
"account",
"account_group_auditory",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this module?

why make this module dependent on it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hbto auditory group account is in addons/vauxoo, and Odoo-ifrs is dependent because if you want to install only this module, Odoo-ifrs must know that module, since the acl are added to the group Auditor read-only which is in account_group_auditory

@hbto
Copy link
Contributor

hbto commented Apr 14, 2015

Abort this proposal, @nhomar & @hugho-ad , this module is not intended to be dependent on all the other module on which account_group_auditory is dependent,

please use another approach, if the final version of the module is to make ifrs a cumbersome module
dependent on many other modules I will not support it.

my intention with option b) in the other PR, then is to be changed,

create an auditory module on addons-vauxoo, which can be dependent on as many modules as possible,

leave free and untouched ifrs.

the only change to be accepted in ifrs is a new group in security section and the regarding ACL no more.
that was set in proposal a).

Do not add dependencies on ifrs.

Best Regards.

@nhomar
Copy link
Member

nhomar commented Apr 14, 2015

On Mon, Apr 13, 2015 at 7:53 PM, Hbto [ Vauxoo ] notifications@github.com
wrote:

Abort this proposal, @nhomar https://github.com/nhomar & @hugho-ad
https://github.com/hugho-ad , this module is not intended to be
dependent on all the other module on which account_group_auditory is
dependent,

please use another approach, if the final version of the module is to make
ifrs a cumbersome module
dependent on many other modules I will not support it.

my intention with option b) in the other PR, then is to be changed,

create an auditory module on addons-vauxoo, which can be dependent on as
many modules as possible,

leave free an untouched ifrs.

the only change to be accepted in ifrs is a new group in security section
and the regarding ACL no more.
that was set in proposal a).

Do not add dependencies on ifrs.

Can we have a meeting to explain this first please.

Regards.-

Nhomar Hernandez
CEO Vauxoo.
Site: http://vauxoo.com
Twitter: @nhomar
Blog: http://geronimo.com.ve
LPUser: http://launchpad.net/~nhomar
Odoo Gold Partner

@hbto
Copy link
Contributor

hbto commented Apr 14, 2015

Having met with @nhomar I agree on the approach of depending on account_group_aditory,

now all the critics will be addressed on account_group_auditory

@hugho-ad
Copy link
Contributor Author

@hbto , @nhomar
This is ready to be merged,

@JulioSerna
Copy link
Contributor

👍

nhomar added a commit that referenced this pull request Apr 20, 2015
…gho-ad

[ADD][ifrs_report] TASK#3157,ISSUE#558
@nhomar nhomar merged commit e3a5c99 into Vauxoo:8.0 Apr 20, 2015
@nhomar nhomar deleted the 8.0-ifrs_report-#vx3157-dev-hugho-ad branch April 20, 2015 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants