[1.12.2] Crash when creating Terrasteel

[wiloxe]

Version Information

Forge version: forge-14.23.3.2678
Botania version: r1.10-354

Further Information

Link to crash log: https://pastebin.com/PYRHe7fQ
Steps to reproduce:

1. Build the structure needed to make Terrasteel
2. Drop all required items to make Terrasteel
3. Then crash!

What I expected to happen:
Without any crash, Terrasteel should be created and I can continue my day.

What happened instead:
A second or two after providing with mana the game froze and crashed.

Comments:
I don't know if this is mod conflict-related, however, since the crash report only reports Botania I cannot say it is.

[williewillus]

Does it happen without any other mods? (just baubles, botania, and forge)

[wiloxe]

Okay, so it turns out to be a mod conflict-related issue with VanillaFix.
DimensionalDevelopment/VanillaFix#18

[Runemoro]

Not a conflict, VanillaFix helps mod authors to find bugs which are otherwise difficult to find by crashing (in 1.0.1) or showing a warning screen (in 1.0.2+) in an exception during a scheduled executable.

[williewillus]

I still want to see if this is reproducible without any other mods.
The particle ID in the packet is somehow changing (it's trying to show another particle effect unrelated to terrasteel crafting) which should never happen unless there's network/memory corruption or a mod's messing with the network system.

[wiloxe]

I was unable to reproduce when testing with no other mods than Botania, Baubles, and Forge.

[Hillage]

Howdy,

As stated above, I do not get this bug with only Botania and Baubles. As soon as I add VanillaFix it crashes.

With Botania, Baubles, VanillaFix the following crashlog occurs:

https://paste.dimdev.org/bazujeseze.txt

I will be commenting on the issue over at VanillaFix's github as well

edit: I guess the error that is causing VanillaFix to kick in needs to be fixed. Current workaround is to disable VanillaFix.

[williewillus]

without vanilla fix are there errors in the log even if it doesn't crash?

[Runemoro]

@williewillus Yes, there should be. The error is caused by an uncaught exception in a scheduled task (Minecraft.getMinecraft().addScheduledTask, Minecraft.getIntegratedServer().addScheduledTask). All that VanillaFix does is inform the player that something went wrong and make a report which helps them and the mod author solve their problems.

Also, newer versions of VanillaFix only display a warning to the player (which can be disabled), rather than completely crashing.

[williewillus]

I want to see a log to be 100% sure; there is no way I am sending the wrong effect ID there, so I suspect another mod causing network or memory corruption.

The packet is sent from here

But the exception is occurring here in a completely different effect ID.

This is nonsensical and also doesn't happen in the dev workspace so it has to be a conflict or something hacking around.

[Hillage]

Baubles and Botania ONLY, the following is thrown in the log (repeatedly as the process goes on):

https://pastebin.com/kQRC2hN5

Tested with creative pool, agg plate setup, and both mana spreader and spark in different tests.

[williewillus]

Ah, I derped. Blame C-style switch for being dumb :P
Fixed in next release.