Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.20.1 - PistonStructureResolverMixin Server crash #4527

Closed
Gamerbolts opened this issue Dec 30, 2023 · 8 comments · Fixed by #4528
Closed

1.20.1 - PistonStructureResolverMixin Server crash #4527

Gamerbolts opened this issue Dec 30, 2023 · 8 comments · Fixed by #4528

Comments

@Gamerbolts
Copy link

Mod Loader

Forge

Minecraft Version

1.20.1

Botania version

1.20.1-442

Modloader version

47.2.16

Modpack info

Heavily modified ATM9

The latest.log file

https://gist.github.com/Gamerbolts/528f6e8aa1f5e2229bacc0a3c0531035

Issue description

I am not sure what happened I was running around exploring the world and crashed. I think a piston did something somewhere I could not see.

Steps to reproduce

No response

Other information

crash-2023-12-30_15.29.56-server.txt

@TheRealWormbo
Copy link
Collaborator

How heavily modified? You appear to be running a bunch of Fabric mods on a post-fork Forge version, which means you use a Fabric compatibility mod and a Forge version that may or may not be unstable.

The crash your log file shows does indeed happen from a mixin for piston pushing logic, which requires Forge's access transformer features to work properly. This works with Forge versions 47.1.3 (the latest version before most Forge devs forked NeoForged) and 47.1.47, but as not been tested on any newer version of the mod loader. Can you maybe downgrade to one of those two versions and check if it still causes issues?

TheRealWormbo added a commit to TheRealWormbo/Botania that referenced this issue Dec 30, 2023
…iMods#4527)

Fixes PistonStructureResolverMixin crash on Forge whenever blocks are moved by a piston, force relay or force lens.
@Gamerbolts
Copy link
Author

Quite heavily modded. I added about 200 mods to ATM9 which gave me a total of 678. I do have neoforge connector and forgified fabric in the pack. I'll try those two earlier versions of forge to see if that works. Thanks for the help

@lgc2333
Copy link

lgc2333 commented Jan 1, 2024

@TheRealWormbo
Copy link
Collaborator

Thank you. A fix is already in the pipeline and probably gets released soon.

@liny-fox
Copy link

liny-fox commented Jan 2, 2024

Just tested by creating a blank modpack in the curse forge loader and installing botaina and its required dependencies and placing a piston and a button next to it and the server instantly crashes when pressing the button.

@lgc2333

This comment was marked as outdated.

@TheRealWormbo
Copy link
Collaborator

try this before the next version release https://github.com/lgc2333/Botania/actions/runs/7383125195

What does that do? (And how does it relate to this bug?)

artemisSystem pushed a commit that referenced this issue Jan 2, 2024
Fixes #4527: PistonStructureResolverMixin crash on Forge whenever blocks
are moved by a piston, force relay, or force lens.
@artemisSystem
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

5 participants