Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of dask, update to pandas 2.0, fix tests #497

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

amrit110
Copy link
Member

@amrit110 amrit110 commented Nov 3, 2023

PR Type ([Feature | Fix | Documentation | Test])

Fix

Short Description

  • Removes use of dask, this has been done in cycquery as well. Batching is done just using pandas.
  • Bump up to use pandas 2.0. There are some deprecation warnings that need to be fixed.
  • Fixed tests based on isna() bug fix.
  • Remove use_cases/cxr_classification.ipynb notebook

Tests Added

...

@amrit110 amrit110 added refactor Refactor existing code, with same or similar functionality tests Unit or Integration tests labels Nov 3, 2023
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #497 (1eb5fbc) into main (d9a6258) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #497      +/-   ##
==========================================
- Coverage   61.36%   61.32%   -0.05%     
==========================================
  Files          86       86              
  Lines        8257     8248       -9     
==========================================
- Hits         5067     5058       -9     
  Misses       3190     3190              
Files Coverage Δ
cyclops/process/feature/feature.py 73.84% <ø> (ø)
cyclops/process/feature/handle_types.py 79.91% <ø> (ø)
cyclops/utils/file.py 99.07% <100.00%> (-0.08%) ⬇️

Impacted file tree graph

@amrit110 amrit110 merged commit 03097ef into main Nov 3, 2023
9 checks passed
@amrit110 amrit110 deleted the remove_dask_dependency branch November 3, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor existing code, with same or similar functionality tests Unit or Integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant